fix: default turn the option on#171
Closed
WalkerLiuFei wants to merge 2 commits intohyperliquid-dex:masterfrom
Closed
fix: default turn the option on#171WalkerLiuFei wants to merge 2 commits intohyperliquid-dex:masterfrom
WalkerLiuFei wants to merge 2 commits intohyperliquid-dex:masterfrom
Conversation
traderben
requested changes
Jul 3, 2025
hyperliquid/utils/signing.py
Outdated
|
|
||
| def action_hash(action, vault_address, nonce, expires_after): | ||
| data = msgpack.packb(action) | ||
| data = msgpack.packb(action,use_bin_type=True) |
Contributor
There was a problem hiding this comment.
This is already the default value: https://msgpack-python.readthedocs.io/en/latest/api.html
Author
There was a problem hiding this comment.
In earlier versions, this flag defaults to False. Python’s dependency management can be chaotic for those are not familier with Python. When they using the wrong msgpack version would quickly becomes a nightmare. I ran into this exact issue and ended up spending a whole night tracking down .
Contributor
There was a problem hiding this comment.
pyproject.toml specifies that the minimum required version of msgpack is 1.0.5 so that shouldn't be possible. I don't think it's worth programming this defensively
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.